Add STDEXEC_MAIN_PROJECT and STDEXEC_INSTALL to CMake#1931
Merged
ericniebler merged 5 commits intoNVIDIA:mainfrom Mar 17, 2026
Merged
Add STDEXEC_MAIN_PROJECT and STDEXEC_INSTALL to CMake#1931ericniebler merged 5 commits intoNVIDIA:mainfrom
ericniebler merged 5 commits intoNVIDIA:mainfrom
Conversation
ericniebler
reviewed
Mar 14, 2026
Collaborator
ericniebler
left a comment
ericniebler
left a comment
There was a problem hiding this comment.
this looks good. just one comment.
Collaborator
|
/ok to test b9a585f |
…uild testing was specified.
Collaborator
|
/ok to test 88ccf54 |
Collaborator
|
/ok to test fc00a6d |
ericniebler
approved these changes
Mar 17, 2026
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is common practice to be able to disable install targets because they can conflict with in-tree builds (for example when
stdexecis added via CPM).Most projects use a top-level project check to enable installs by default when
stdexecis the main project and otherwise disable them. I've applied the same pattern here and also replaced the remainingBUILD_TESTINGusages withSTDEXEC_BUILD_TESTS.stdexecis the top-level project.STDEXEC_MAIN_PROJECTandSTDEXEC_INSTALL.BUILD_TESTINGwithSTDEXEC_BUILD_TESTS.asioexec,tbbexec, etc., to avoid conflicts when used as a dependency.At least resolves my pain with the install targets when pulling stdexec via CPM/FetchContent or add_subdirectory.